Skip to content

Conversation

@chrisminett
Copy link
Member

@chrisminett chrisminett commented Feb 10, 2025

  • Type declarations for parameters and return types.
  • Drop support for PHP versions <= v8.0.

None of the type declarations are more restrictive than the current expected implementation, e.g. adding mixed, so this does not HAVE to be a major version.

@chrisminett chrisminett added the major-version Release MUST be major version increment label Feb 10, 2025
@chrisminett chrisminett self-assigned this Feb 10, 2025
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (c54e17f) to head (7ed407e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #15      +/-   ##
============================================
- Coverage     97.69%   97.66%   -0.03%     
  Complexity      128      128              
============================================
  Files             9        9              
  Lines           347      343       -4     
============================================
- Hits            339      335       -4     
  Misses            8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisminett chrisminett added minor-version Release SHOULD be minor version increment and removed major-version Release MUST be major version increment labels Feb 10, 2025
@chrisminett chrisminett merged commit 36b83da into main Feb 10, 2025
10 checks passed
@chrisminett chrisminett deleted the php81 branch February 10, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor-version Release SHOULD be minor version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants